This repository has been archived by the owner on Apr 25, 2020. It is now read-only.
Check if dhclient.conf exists & Check if dns_domain is truthy #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensallen
commented
May 13, 2015
bensallen
commented
- Don't edit dhclient.conf if file doesn't already exist, otherwise lineinfile fails without create=yes.
- Allow user to unset the default dns_domain: localhost, by setting it to "dns_domain: " by checking if dns_domain is truthy in template.
…s_domain to see if its truthy or falsey, i.e. if somewhere in a playbook we set dns_domain to None
…led by default to match existing behavior
…instead of a conditional based on os_family, cleanup logic of conditional
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.