Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
After finding out that riverscn's fork was reading data at incorrect size, I decided to attempt on adding SoftwareSerial support to this library to support ESP8266
So far it build successfully, but it won't link. I'm not proficient with C++ so I'm posting here in case anyone would know how to fix this:
If I comment out the destructor in
IPmsSerial
then it build just fine, but I feel like that would break something else...