-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(3942): added support for NativeSyntheticEvent #3972
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
@@ -1,4 +1,5 @@ | |||
import * as React from 'react'; | |||
import { NativeSyntheticEvent } from 'react-native'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { NativeSyntheticEvent } from 'react-native'; | |
import type { NativeSyntheticEvent } from 'react-native'; |
@@ -2,6 +2,7 @@ import deepmerge from 'deepmerge'; | |||
import isPlainObject from 'lodash/isPlainObject'; | |||
import cloneDeep from 'lodash/cloneDeep'; | |||
import * as React from 'react'; | |||
import { NativeSyntheticEvent } from 'react-native' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { NativeSyntheticEvent } from 'react-native' | |
import type { NativeSyntheticEvent } from 'react-native' |
Let's actually just inline the type instead of requiring the user to install export interface NativeSyntheticEvent<T>
extends React.BaseSyntheticEvent<
T,
React.ElementRef<React.ComponentType<any>>,
React.ElementRef<React.ComponentType<any>>
> {} And please add a changeset :) |
Closes #3942