avoid custom creational context implementations #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manovotn
approved these changes
May 21, 2023
|
This is exactly what I meant in #453 (comment) |
In the next release, these tests will be rewritten to use a TCK SPI and then enabled again.
Ladicek
force-pushed
the
avoid-custom-creational-context
branch
from
2b49823
to
af9783f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes an unused class
CreationalContextImpland replaces most usages ofMockCreationalContextwithBeanManager.createCreationalContext()(because those places don't really use theMockCreationalContextfor verifying anything). The 2 remaining usages ofMockCreationalContextare added to the canonical exclude list with the plan to enable them again in subsequent release, after migrating to a TCK SPI (#452).Fixes #453