Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate TangentBinormalGenerator #2144

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Deprecate TangentBinormalGenerator #2144

wants to merge 6 commits into from

Commits on Nov 9, 2023

  1. Deprecate TangentBinormalGenerator

    @riccardobl
    riccardobl committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    94fb47d View commit details
    Browse the repository at this point in the history

  2. Print a SEVERE log instead of throwing an exception when trying to co… 

    …mpute tangent for unsupported mesh types.

Add generate(Mesh) method to match TangentBinormalGenerator
    @riccardobl
    riccardobl committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    d82b9a7 View commit details
    Browse the repository at this point in the history

  3. Move methods used to generate debug lines for tangent and normals fro… 

    …m TangentBinormalGenerator to TangentUtils
    @riccardobl
    riccardobl committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    7e34589 View commit details
    Browse the repository at this point in the history

  4. Replace most of the occurencies of TangentBinormalGenerator with Mikk… 

    …tspace
    @riccardobl
    riccardobl committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    07ff207 View commit details
    Browse the repository at this point in the history

  5. Add patch to supported mesh types

    @riccardobl
    riccardobl committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    3f17956 View commit details
    Browse the repository at this point in the history

  6. Fix

    @riccardobl
    riccardobl committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    32d37ef View commit details
    Browse the repository at this point in the history