Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no wrapperLength for empty coverage #210

Merged
merged 1 commit into from
Oct 5, 2023
Merged

fix: no wrapperLength for empty coverage #210

merged 1 commit into from
Oct 5, 2023

Conversation

AriPerkkio
Copy link
Contributor

@SimenB
Copy link
Member

SimenB commented Oct 4, 2023

there's conflicts here

@AriPerkkio AriPerkkio force-pushed the fix/wrapperlength-empty-coverage branch from 5cb4a64 to a1c029d Compare October 4, 2023 18:43
@AriPerkkio
Copy link
Contributor Author

Rebased master here. No notable changes to implementation or test cases.

SimenB
SimenB approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, thanks!

@SimenB SimenB merged commit bde6de2 into istanbuljs:master Oct 5, 2023
7 checks passed
@github-actions github-actions bot mentioned this pull request Oct 5, 2023
Merged
@AriPerkkio AriPerkkio deleted the fix/wrapperlength-empty-coverage branch October 5, 2023 11:49
@SimenB
Copy link
Member

SimenB commented Oct 5, 2023

https://github.com/istanbuljs/v8-to-istanbul/releases/tag/v9.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrapperLength should not be applied to empty coverage
2 participants
@AriPerkkio @SimenB