Fix testsuite #152
Draft
Fix testsuite #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of appending at the end of the test module, directly check the contents of register ".
The locally defined `withNeovimEmbedded` was never called with a file to open anyway, so we can just use the recommended `runInEmbeddedNeovim` directly.
Flake lock file updates:
• Updated input 'nixpkgs':
'github:NixOS/nixpkgs/e1d501922fd7351da4200e1275dfcf5faaad1220' (2024-03-23)
→ 'github:NixOS/nixpkgs/bf446f08bff6814b569265bef8374cfdd3d8f0e0' (2024-05-16)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had these commits lying around locally for a while. I've attempted to fix the testsuite when running it under Nix, especially by ensuring that both
nvimandagdaare available to the tests. Now CI at least fails with some reasonable errors instead of reporting "nonvimin $PATH" as "all OK".In particular fe25c8e, 8f12732 and ff67545 could be of interest. But there's other commits in here that are perhaps independently useful. Feel free to cherry-pick anything that's useful.