Skip to content

Commit

Permalink
[Reactor] Remove vestigial ReactorSurface code from WallBase
Browse files Browse the repository at this point in the history
  • Loading branch information
speth authored and ischoegl committed Aug 9, 2023
1 parent 3ee75b0 commit 4b30fa7
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 13 deletions.
7 changes: 1 addition & 6 deletions include/cantera/zeroD/Wall.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,11 @@
#define CT_WALL_H

#include "cantera/base/ctexceptions.h"
#include "cantera/zeroD/ReactorSurface.h"
#include "cantera/zeroD/ReactorBase.h"

namespace Cantera
{

class Kinetics;
class SurfPhase;
class Func1;

/**
Expand All @@ -24,7 +21,7 @@ class Func1;
class WallBase
{
public:
WallBase();
WallBase() = default;

virtual ~WallBase() {}
WallBase(const WallBase&) = delete;
Expand Down Expand Up @@ -122,8 +119,6 @@ class WallBase
ReactorBase* m_left = nullptr;
ReactorBase* m_right = nullptr;

vector<ReactorSurface> m_surf;

//! current reactor network time
double m_time = 0.0;

Expand Down
1 change: 1 addition & 0 deletions src/zeroD/ConstPressureMoleReactor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
// at https://cantera.org/license.txt for license and copyright information.

#include "cantera/zeroD/Wall.h"
#include "cantera/zeroD/ReactorSurface.h"
#include "cantera/zeroD/FlowDevice.h"
#include "cantera/zeroD/ConstPressureMoleReactor.h"
#include "cantera/base/utilities.h"
Expand Down
1 change: 1 addition & 0 deletions src/zeroD/ConstPressureReactor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include "cantera/zeroD/ConstPressureReactor.h"
#include "cantera/zeroD/FlowDevice.h"
#include "cantera/zeroD/Wall.h"
#include "cantera/zeroD/ReactorSurface.h"
#include "cantera/kinetics/Kinetics.h"
#include "cantera/thermo/SurfPhase.h"
#include "cantera/base/utilities.h"
Expand Down
7 changes: 0 additions & 7 deletions src/zeroD/Wall.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,10 @@
#include "cantera/base/stringUtils.h"
#include "cantera/numerics/Func1.h"
#include "cantera/zeroD/Wall.h"
#include "cantera/thermo/SurfPhase.h"

namespace Cantera
{

WallBase::WallBase() : m_surf(2) {}

bool WallBase::install(ReactorBase& rleft, ReactorBase& rright)
{
// check if wall is already installed
Expand All @@ -23,15 +20,11 @@ bool WallBase::install(ReactorBase& rleft, ReactorBase& rright)
m_right = &rright;
m_left->addWall(*this, 0);
m_right->addWall(*this, 1);
m_surf[0].setReactor(&rleft);
m_surf[1].setReactor(&rright);
return true;
}

void WallBase::setArea(double a) {
m_area = a;
m_surf[0].setArea(a);
m_surf[1].setArea(a);
}

double Wall::velocity() const {
Expand Down

0 comments on commit 4b30fa7

Please sign in to comment.