Revert to CFITSIO for table i/o using a re-usable cfitsio library #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olebole
changed the title
olebole
force-pushed
the
reuse-cfitsio
branch
from
b2562b6
to
f60e12f
Compare
This partially reverts commit d4b7ce0.
The libtbtables.a was changed in v2.16 to use SPP fitsio from earlier uses of the fortran version under the assumption that they were equivalent. However, there is a bug in the fortran version of ftdrow() when called by the TDIFFER task in which the output table doesn't have its NAXIS2 value properly updated for FITS tables causing the task to exit. The cfitsio code acknowledges the value may not be correct and so uses an internal data structure value for the 'nrows' rather than the keyword, but equivalent functionality does not exist in the fortran version. A similar problem exists when inserting rows but this is not called from any existing NTTOOLS tasks. This change fixes a bug in the GEMINI.GSEEING task which is the only task known to call TDIFFER.
olebole
force-pushed
the
reuse-cfitsio
branch
from
f60e12f
to
d2cbcb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #379: it switches to cfitsio for tbtable, but installs cfitsio in
vendor(where it was until 2.17.1). This has a few advantages:This is also for discussion with @noirlab-iraf-admin resp. @mjfitzpatrick for clarification with NOIRLab IRAF. Original statement to switch to cfitsio in tbtable by @mjfitzpatrick in 5d4c168 :