-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TxnDatastore namespace and keytransform wrappers #210
base: master
Are you sure you want to change the base?
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
@i-norden I don't see much has changed since last time? |
Ah apologies, I embedded but with a named field instead of anonymously so it still had the methods reimplemented but only to fall directly through. Fixed now! |
Also embedded |
@i-norden I'm not going to have much time in the next few days, but have a look to #211. I think it does what you want. You don't need to re-implement anything, you just need to wrap stuff in other stuff. If I haven't done something completely wrong, just take that, improving the naming of things and test it a bit. |
Thanks @hsanjuan! I appreciate the feedback. I'll take a look and test out that wrapper. |
@i-norden is this PR still necessary or were you able to solve it with mentioned wrapper? |
This PR introduces namespace and keytransform wrappers for the go-datastore
TxnDatastore
. This is in order to support aGetMany
boxo blockstore implementation that leverages theTxnDatastore
for batched reads which, in turn, is ultimately for supporting parallel traversal methods in go-hamt-ipld and go-amt-ipld.boxo/blockstore PR that uses this: ipfs/boxo#492