-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a native (Kotlin) based implementation (in a subfolder) #48
Open
jmazzahacks
wants to merge
61
commits into
ipfs-shipyard:main
Choose a base branch
from
Really-Bad-Apps:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…just launch a browser now
…ake it work with livedata
… it in a preference
@jmazzahacks This is a pretty impressive pr! I chose to use ionic here because I don't have experience with kotlin or Swift, so this allows me to maintain one code base in JS. I suggest keeping this maintained on your fork, I'd be happy to link to it in the project's README as well as the https://github.com/Really-Bad-Apps/AndroidIPFSRouter library for devs who prefer a more native experience. Thanks! |
That sounds fine to me. I'm happy I was able to contribute something
finally after 1-2 years of jawboning about it.
Thanks!
…On Sat, Jan 13, 2024 at 9:04 PM Dave Justice ***@***.***> wrote:
@jmazzahacks <https://github.com/jmazzahacks> This is a pretty impressive
pr!
I chose to use ionic here because I don't have experience with kotlin or
Swift, so this allows me to maintain one code base in JS.
I suggest keeping this maintained on your fork, I'd be happy to link to it
in the project's README as well as the
https://github.com/Really-Bad-Apps/AndroidIPFSRouter library for devs who
prefer a more native experience.
Thanks!
—
Reply to this email directly, view it on GitHub
<#48 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAA3HUYRSPPU64AWU75Y53YOM4L5AVCNFSM6AAAAABBSBVOXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJQHAZDENBYGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Jason Hudgins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mostly complete and functional port of the ionic code base into a java/kotlin native implementation.
Some of the bits that no longer work in the original app (web3.storage) etc have not been ported.