This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
fixing TrytesCompatible so that its no longer generic. #343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes an error found by using the Pylance LS in basic typechecking mode.
I'm assuming the original code was meant to be "str or bytes". Most the docstrings mention
Byte string or bytearray.
Using a constrained TypeVar like AnyStr in a Union is usually a mistake.
TrytesCompatible = Union[AnyStr, bytearray, 'TryteString'] defines a generic type alias, which can be legitimate. To use it properly, you'd need to provide a type argument that is compatible with the AnyStr type variable.
TrytesCompatible[str] or TrytesCompatible[bytes] or TrytesCompatible[AnyStr] would all be allowed.
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Ran all tests
python setup.py test
Change checklist
Add an
x
to the boxes that are relevant to your changes, and delete any items that are not.docs/
directory and/ordocstring
s in source code)