-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add indexer /outputs route #1246
Merged
thibault-martinez
merged 16 commits into
iotaledger:1.1
from
Thoralf-M:new-indexer-route
Sep 19, 2023
Merged
Add indexer /outputs route #1246
thibault-martinez
merged 16 commits into
iotaledger:1.1
from
Thoralf-M:new-indexer-route
Sep 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
force-pushed
the
new-indexer-route
branch
from
September 18, 2023 12:07
a5b9279
to
6d3058f
Compare
sdk/src/wallet/account/operations/syncing/addresses/output_ids/mod.rs
Outdated
Show resolved
Hide resolved
3 tasks
kwek20
previously approved these changes
Sep 18, 2023
DaughterOfMars
previously approved these changes
Sep 18, 2023
Thoralf-M
dismissed stale reviews from DaughterOfMars and kwek20
via
September 19, 2023 07:40
08e4982
thibault-martinez
previously approved these changes
Sep 19, 2023
DaughterOfMars
previously approved these changes
Sep 19, 2023
Thoralf-M
dismissed stale reviews from DaughterOfMars and thibault-martinez
via
September 19, 2023 09:59
707b52f
Co-authored-by: Thibault Martinez <[email protected]>
Co-authored-by: Thibault Martinez <[email protected]>
Thoralf-M
commented
Sep 19, 2023
thibault-martinez
previously approved these changes
Sep 19, 2023
thibault-martinez
approved these changes
Sep 19, 2023
DaughterOfMars
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add indexer /outputs route with QueryParameter::UnlockableByAddress
Also updated the wallet to make use of it, if all output types should be synced, because this reduced the amount of requests as can be seen in the cli logs below.
Links to any relevant issues
Closes #1241
Type of change
How the change has been tested
Running nodejs and python and with the cli wallet
Sync before this change
Sync after this change
Change checklist