Fix using latest emscripten #669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emscripten 3.1.27 reduced the stack size from 5MB to 64KB. This caused run-time errors: Uncaught RuntimeError: index out of bounds Co-authored-by: James Darpinian <[email protected]>
Co-authored-by: James Darpinian <[email protected]>
Co-authored-by: James Darpinian <[email protected]>
|
I'm about to update #658, maybe hold off a bit? |
|
OK #658 is updated, let me know if the changes are OK |
|
The changes were merged via #658 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes running using the latest emscripten (3.1.61) which changed the default stack size. (I was testing ioquake3 using emscripten 3.1.20 from 2022.) This pulls a few changes from #658.