Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
first this PR is not necessarily there to be merged (certainly not in the master branch). It is there to try out if it is possible to use jest as a testrunner for unit tests in ionic.
I started integration unit tests with karma and jasmine which is already a great improvement if we want to test our applications. After having seen the usage of jest in a workshop it seems that there are some really great features that could make testing ionic/angular even more pleasant.
It would be great to have some feedback from the ionic team about the usage of jest. Feel free to try out the modifications in this PR and give feedback. I am just beginning with unit tests and don't understand much yet but hope ionic becomes a pleasant environment for testing :)
There is one error with jest that I couldn't resolve yet, as soon as we add the NavController to page 1 jest shows this error:
No provider for NavController! at Error (native)
@danielsogl this might interest you aswell