Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor content loss backport #401

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Editor content loss backport #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d434c42
comments: fix comment editor loses content on focus change
Samk13 Aug 6, 2024
02e4798
release: v4.1.2
max-moser Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
Changes
=======

Version 4.1.2 (released 2024-08-06)

- comments: fix comment editor loses content on focus change

Version 4.1.1 (released 2024-08-01)

- comments: fix jumping cursor
Expand Down
2 changes: 1 addition & 1 deletion invenio_requests/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
current_requests_service,
)

__version__ = "4.1.1"
__version__ = "4.1.2"

__all__ = (
"__version__",
Expand Down
6 changes: 5 additions & 1 deletion invenio_requests/assets/semantic-ui/js/invenio_requests/request/actions/RequestAction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// This file is part of InvenioRequests
// Copyright (C) 2022 CERN.
// Copyright (C) 2024 KTH Royal Institute of Technology
//
// Invenio RDM Records is free software; you can redistribute it and/or modify it
// under the terms of the MIT License; see LICENSE file for more details.
Expand Down Expand Up @@ -69,7 +70,10 @@ export class RequestAction extends Component {
<Modal.Description>
{i18next.t("Add comment (optional)")}
<Divider hidden />
<RichEditor onChange={this.onCommentChange} />
<RichEditor
inputValue={() => this.state.actionComment}
onChange={this.onCommentChange}
/>
</Modal.Description>
</Modal.Content>
</RequestActionModal>
Expand Down