access request: update guest request payload #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntarocco
approved these changes
Aug 11, 2023
| ReactDOM.render( | ||
| <InvenioRequestsApp | ||
| request={request} | ||
| defaultQueryParams={defaultQueryParams} | ||
| overriddenCmps={overriddenComponents} | ||
| overriddenCmps={overrideStore.getAll()} |
There was a problem hiding this comment.
I would not do that to avoid, I am not sure in which case, replacing an already defined id in the global store.
We should prefer the pattern:
{ ...defaultComponents, ...overriddenComponents },
instead.
* add an overridable for the timeline header * inject permissions prop * closes inveniosoftware/invenio-rdm-records#1395
ntarocco
force-pushed
the
update-request-payload-in-the-request-detail-page
branch
from
72db482
to
232db7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: the permissions for request.payload updation should be handled in separate PR (this TODO https://github.com/inveniosoftware/invenio-requests/pull/343/files#diff-4b568e443f92c06d4ea44587cf21b1134cfaff1f5bf4ceb88076ae894c452f0fR44)
The task is already created: inveniosoftware/invenio-rdm-records#1402