UI: display all affiliations #1875
Open
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlinmack
commented
Nov 12, 2024
...semantic-ui/js/invenio_rdm_records/src/deposit/fields/CreatibutorsField/CreatibutorsField.js
Show resolved
Hide resolved
zzacharo
approved these changes
Nov 13, 2024
...semantic-ui/js/invenio_rdm_records/src/deposit/fields/CreatibutorsField/CreatibutorsField.js
Outdated
Show resolved
Hide resolved
zubeydecivelek
approved these changes
Nov 13, 2024
| @@ -27,10 +27,10 @@ const creatibutorNameDisplay = (value) => { | |||
|
|
|||
| const familyName = _get(value, "person_or_org.family_name", ""); | |||
| const givenName = _get(value, "person_or_org.given_name", ""); | |||
| const affiliationName = _get(value, `affiliations[0].name`, ""); | |||
| const affiliations = value?.affiliations.map((affiliation) => affiliation.name); | |||
There was a problem hiding this comment.
Question: Looks like this works fine from the screenshot you have shared. Just double checking that affiliations is not silently failing in the console when it's not present, I guess it will be an empty list which is fine, otherwise we would also need to add the ? operator.
There was a problem hiding this comment.
Nope no failure in console :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Currently we just show the first affiliation. After:
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: