Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deposit: change creatributor and license item button order #1811

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tmorrell
Copy link
Contributor

@tmorrell tmorrell commented Sep 4, 2024

❤️ Thank you for your contribution!

Description

This PR reverts #1784 and re-implements #1389 with the addition of the license field.

The current button order with Remove on the far right makes it too easy to accidentally delete a creatributor when editing a record. It also isn't consistent with the button order guidelines https://inveniordm.docs.cern.ch/develop/best-practices/ui/#button-colors-and-order

Change in this PR:
Screenshot 2024-09-05 at 2 42 55 PM

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

This PR was automatically marked as stale.

@github-actions github-actions bot added the stale label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant