Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiles: don't process images <= tile dimensions #1760

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yashlamba
Copy link
Member

Currently we are processing images less than the tile size into pyramidal tiffs, which leads to corrupt files ptif. We would want to skip the processing for those images.

The config design is not the best and I would probably change how we load the default args here:

return (
self._params
or current_app.config.get("IIIF_TILES_CONVERTER_PARAMS", {})
or self.default_params
)

Probably, completely removing default_args.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

This PR was automatically marked as stale.

@github-actions github-actions bot added the stale label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant