oai: updated dcat and datacite serializers #1713
Open
+79
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0einstein0
force-pushed
the
OAI-PMH
branch
3 times, most recently
from
2ce1cd6
to
42cadcf
Compare
lnielsen
reviewed
Apr 4, 2024
invenio_rdm_records/records/jsonschemas/records/record-v6.0.0.json
Outdated
Show resolved
Hide resolved
lnielsen
reviewed
Apr 4, 2024
0einstein0
force-pushed
the
OAI-PMH
branch
2 times, most recently
from
ad1dd43
to
a1c10ac
Compare
0einstein0
changed the title
0einstein0
changed the title
0einstein0
force-pushed
the
OAI-PMH
branch
2 times, most recently
from
eebf33d
to
62f5aa6
Compare
ptamarit
approved these changes
Apr 23, 2024
| --> | ||
| --> | ||
| <xsl:if test="$uri != ''"> | ||
| <dct:identifier rdf:datatype="{$xsd}string"><xsl:value-of select="$nameIdentifier"/></dct:identifier> |
There was a problem hiding this comment.
major: So far this file has been fully synchronized with a repository which is not maintained by us:
https://github.com/ec-jrc/datacite-to-dcat-ap/blob/master/datacite-to-dcat-ap.xsl
We need to decide if we want to:
- Diverge with the upstream version
- Propose a contribution to the upstream version (we recently contributed a bug fix)
- Find another way to achieve the expected result in InvenioRDM.
There was a problem hiding this comment.
After some discussions, the decision is that we can:
- Merge this change
- Propose an PR with the same change upstream on https://github.com/ec-jrc/datacite-to-dcat-ap/
ptamarit
reviewed
Apr 23, 2024
|
This PR was automatically marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Closes https://github.com/zenodo/ops/issues/420
Closes https://github.com/zenodo/ops/issues/421
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: