Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js: remove required restriction on fieldSchema #212

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

carlinmack
Copy link
Contributor

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

The only time fieldSchema is only used as follows:

if (fieldSchema?.escape) {
      return <div dangerouslySetInnerHTML={{ __html: value }} />;
}

and when fieldSchema was committed:

e30d0f8

the other reference to this function was not updated:

https://github.com/inveniosoftware/invenio-administration/blob/main/invenio_administration/assets/semantic-ui/js/invenio_administration/src/search/SearchResultItem.js#L68-L80

Therefore I think we can just say it's not required as the implementation accounts for it not having the key

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@carlinmack carlinmack added the bug Something isn't working label May 29, 2024
@alejandromumo alejandromumo merged commit 395fb48 into inveniosoftware:main Jun 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

2 participants