Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept kwargs to be passed to get_api_endpoint #209

Merged

Conversation

karkraeg
Copy link
Member

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

To be able to have an AdminResourceListView after an AdminResourceListView we need to be able to define variable api_endpoints. This enables us to do so while keeping backwards compatibility.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@karkraeg
Copy link
Member Author

karkraeg commented May 24, 2024

this PR is needed to enable inveniosoftware/invenio-vocabularies#310

in order to have the AdminResourceListView handle pid_value dynamically we overwrote the base classes get_api_endpoint and had to make sure that additionals keywords arguments are passed correctly: https://github.com/inveniosoftware/invenio-vocabularies/blob/e7d6f0fba6dc4a445687ffb2fdd4ba9f3546a607/invenio_vocabularies/administration/views/vocabularies.py#L52-L62

@karkraeg karkraeg requested a review from slint May 24, 2024 06:39
@slint slint merged commit 5b6325c into inveniosoftware:main May 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants