Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: proper GIF resize #42

Merged
merged 1 commit into from
Apr 20, 2017
Merged

api: proper GIF resize #42

merged 1 commit into from
Apr 20, 2017

Conversation

omelkonian
Copy link
Contributor

Signed-off-by: Orestis Melkonian [email protected]

@drjova
Copy link
Member

drjova commented Apr 20, 2017

@omelkonian could you please have a look on those issues?

flask_iiif/api.py:33 in public class `MultimediaImage`:
        D300: Use """triple double quotes""" (found """-quotes)
flask_iiif/decorators.py:46 in public function `api_decorator`:
        D401: First line should be in imperative mood; try rephrasing (found 'API')
flask_iiif/__init__.py:92 in public method `init_restful`:
        D401: First line should be in imperative mood; try rephrasing (found 'Setup')

* Adds custom behaviour for resizing GIF images, as `PIL.Image.resize`
  does not work out-of-the-box (addresses #41).

* Additionally passes `save_all=True` as a keyword arguement on
  `PIL.Image.save` when serving the file over HTTP (addresses #41).

* Bumps `Pillow`'s version to 3.4, where they introduce functionality
  for creating GIF images out of individual frame images.

* Updates tests to cover GIF resizing.

Signed-off-by: Orestis Melkonian <[email protected]>
@omelkonian
Copy link
Contributor Author

@drjova ping

@drjova drjova merged commit a7420be into inveniosoftware:master Apr 20, 2017
@omelkonian omelkonian deleted the gif-resize-temp branch April 20, 2017 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants