Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix xml UTF8 encoding #496

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

🐛 Fix xml UTF8 encoding #496

wants to merge 5 commits into from

Conversation

HamzaAlayed
Copy link

@HamzaAlayed HamzaAlayed commented Aug 8, 2023 •
edited
Loading

🐛 Use UTF8 encoding to fix some special characters in xml response and fix this error DOMDocument::loadXML(): PCDATA invalid Char .....

@HamzaAlayed HamzaAlayed changed the title Fix xml utf8 encoding 🐛 Fix xml UTF8 encoding Aug 8, 2023
@HamzaAlayed
📝 change retrun type for function to fix Docblock-defined class, inte…
4cc3be2 
…rface or enum named QuickBooksOnline\API\Core\HttpClients\Integer does not exist
@kkmuffme
Copy link

While this is possible, I don't think that's a good idea.

Why not encode it with UTF-8?

if (mb_detect_encoding($xml_string, 'UTF-8', true) === false) {
        $xml_string = utf8_encode($xml_string);
}

@HamzaAlayed
Copy link
Author

@hlu2 could you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HamzaAlayed @kkmuffme