Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get XSD2PHP via Composer #371

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jterrill
Copy link

@jterrill jterrill commented Oct 21, 2020

Upgrade XSD2PHP package to composer based.

Closes #362

Change Overview:

  • Identified repo for XSD2PHP
  • Identified latest matching version of current embedded version
    • v2.0.5-alpha (v2 was last drop)
  • Added to composer.json
    • "elliotchance/intuit-quickbooks":"^v2.0.5-alpha"
  • Updated compose to pull down asset to vendor directory
  • composer update
  • Deleted embedded version of xsd2php
  • Changed namespace to proper version
    • QuickBooksOnline\API\XSD2PHP\src\com\mikebevz
    • use com\mikebevz\xsd2php\Php2Xml;
  • Verify code is Similar

Note: this library no longer appears to be maintained, this is a capture from last known version.

@jterrill
Copy link
Author

jterrill commented Oct 23, 2020

@abisalehalliprasan Can you add the hacktoberfest lable to this?

@abisalehalliprasan
Copy link
Collaborator

@jterrill : Thanks for the contribution 🚀 . Could you provide an overview of what were the changes so that it would help us break it down?

Yes I shall add the hacktoberfest label once we start reviewing . Thanks for your contribution again.

@jterrill
Copy link
Author

I updated what I did, it is slightly better to pull this in via composer than having it embedded. Original code / site for this is no longer available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade XSD2PHP package to the newer version
2 participants