Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QAT: remove c6xxx and fix maxNumDevices #111

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

mregmi
Copy link
Member

@mregmi mregmi commented Aug 22, 2023

Since We only support 4xxx qat devices, remove unsupported device. Set maxNumDevices to 128.
Signed-off-by: Manish Regmi [email protected]

@uMartinXu
Copy link
Contributor

How do we let our customers know what is 4xxx? what is C6XXX? And how to figure out the QAT device type they are using?

@hershpa hershpa added the qat QAT feature label Aug 22, 2023
@hershpa hershpa added this to the v1.0.1 milestone Aug 22, 2023
@mregmi
Copy link
Member Author

mregmi commented Aug 22, 2023

How do we let our customers know what is 4xxx? what is C6XXX? And how to figure out the QAT device type they are using?

I will add a line in README about QAT hardware versions. We only support only one version for now 4xxx

@hershpa
Copy link
Contributor

hershpa commented Aug 22, 2023

From my understanding, 4xxxx refers to 4th Gen Intel Xeon processors (Sapphire Rapids) and QATlib only supports 4xxxx as well.

@mythi
Copy link

mythi commented Aug 22, 2023

It's not ok to say we only support 4xxx. All in-tree drivers are expected to work but only 4xxx is validated as part of the certification.

@mythi
Copy link

mythi commented Aug 22, 2023

How do we let our customers know what is 4xxx? what is C6XXX? And how to figure out the QAT device type they are using?

Use appropriate NodeFeatureRules setting for the desired QAT PCI ID values

@hershpa
Copy link
Contributor

hershpa commented Aug 30, 2023

@chaitanya1731 can you take a look at this one and ensure the image path is correct? I updated the paths since they were not correct but please double check.

@hershpa
Copy link
Contributor

hershpa commented Aug 30, 2023

This one should be ready to merge? It looks ready to me.

Since We only support 4xxx qat devices, remove unsupported device.
Set maxnumdevices to 128.
Signed-off-by: Manish Regmi <[email protected]>
@chaitanya1731
Copy link
Contributor

@hershpa the 4xxx and maxNumDevices changes looks good.. But I still see the container images SHAs are updated too as a part of this PR as these are already merged.. can you take a look?

@hershpa
Copy link
Contributor

hershpa commented Sep 5, 2023

@hershpa the 4xxx and maxNumDevices changes looks good.. But I still see the container images SHAs are updated too as a part of this PR as these are already merged.. can you take a look?

Done!

@chaitanya1731
Copy link
Contributor

Thanks @mregmi and @hershpa. @uMartinXu this looks good now.

@hershpa
Copy link
Contributor

hershpa commented Sep 5, 2023

Great!

@uMartinXu
Copy link
Contributor

This PR looks good to me.

@uMartinXu uMartinXu merged commit f9cd06e into intel:main Sep 13, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qat QAT feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants