-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QAT: remove c6xxx and fix maxNumDevices #111
Conversation
How do we let our customers know what is 4xxx? what is C6XXX? And how to figure out the QAT device type they are using? |
I will add a line in README about QAT hardware versions. We only support only one version for now 4xxx |
From my understanding, 4xxxx refers to 4th Gen Intel Xeon processors (Sapphire Rapids) and QATlib only supports 4xxxx as well. |
It's not ok to say we only support 4xxx. All in-tree drivers are expected to work but only 4xxx is validated as part of the certification. |
Use appropriate NodeFeatureRules setting for the desired QAT PCI ID values |
@chaitanya1731 can you take a look at this one and ensure the image path is correct? I updated the paths since they were not correct but please double check. |
This one should be ready to merge? It looks ready to me. |
Since We only support 4xxx qat devices, remove unsupported device. Set maxnumdevices to 128. Signed-off-by: Manish Regmi <[email protected]>
@hershpa the 4xxx and maxNumDevices changes looks good.. But I still see the container images SHAs are updated too as a part of this PR as these are already merged.. can you take a look? |
Done! |
Thanks @mregmi and @hershpa. @uMartinXu this looks good now. |
Great! |
This PR looks good to me. |
Since We only support 4xxx qat devices, remove unsupported device. Set maxNumDevices to 128.
Signed-off-by: Manish Regmi [email protected]