Add some runtime metrics of go and nodejs application. #9
Conversation
Add more runtime metrics of go and nodejs application
Add nodejs auto instrumentation
Move runtime metrics monitoring code to a separate place
Remove blank line
| @@ -0,0 +1,46 @@ | |||
| // Copyright The OpenTelemetry Authors | |||
There was a problem hiding this comment.
name it to runtime_metrics.go, per the naming convention of go.
|
|
||
| func recordRuntimeMetrics(meter metric.Meter) error { | ||
| // Create metric instruments | ||
| gcPause, err := meter.Float64ObservableGauge("go_gc_pause") |
There was a problem hiding this comment.
Could we follow the same naming pattern used by other metrics from community semconv, suppose that we will submit pr to community for these missing metrics, and how would we propose the metrics naming that can be acceptable by the community.
| @@ -8,11 +8,32 @@ | |||
| ## Note: the spanmetrics exporter must be included in the exporters array | |||
There was a problem hiding this comment.
How about create this otel col config file into a separated folder such as /instana, to host everything specific to Instana. With that, it would be a bit easier for us to keep up with the community changes when we sync from upstream.
| otlp/instana: | ||
| endpoint: | ||
| headers: | ||
| x-instana-key: |
There was a problem hiding this comment.
Do we need to add some comments here to explain what this means for end users, where to find get it, and why we need this?
| @@ -0,0 +1,236 @@ | |||
| // Copyright The OpenTelemetry Authors | |||
There was a problem hiding this comment.
It was usually suggested to use snake_case for node.js filename, e.g.: runtime-metrics.js
| @@ -9,6 +9,7 @@ const { FlagdProvider} = require('@openfeature/flagd-provider'); | |||
| const flagProvider = new FlagdProvider(); | |||
|
|
|||
| const logger = require('./logger'); | |||
| const runtimeMetrics = require('./runtimeMetrics'); | |||
There was a problem hiding this comment.
Are we instrumented the nodejs app using two approaches at the same time, the one from community vs. the one from our side? Instead of modifying the business code, can we move this to opentelemetry.js?
Changes
Add some runtime metrics of go and nodejs application. At the same time, we will gradually contribute these additional metrics to the community.
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.