Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #63

Open
wants to merge 59 commits into
base: patchwork
Choose a base branch
from
Open

Revert #63

wants to merge 59 commits into from

Commits on Jun 3, 2024

  1. hide comment highlights if timeline sidebar is open

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    de3c038 View commit details
    Browse the repository at this point in the history

  2. reset history state when switching to review mode

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    6c43b9c View commit details
    Browse the repository at this point in the history

  3. create a valid range when trying to comment on the end of the document

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    8a0215d View commit details
    Browse the repository at this point in the history

  4. filter out comments on empty ranges

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    e012520 View commit details
    Browse the repository at this point in the history

  5. add global keyboard shortcut cmd+m+shift to comment

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    622ea3b View commit details
    Browse the repository at this point in the history

  6. handle setSelectedAnchors if selection is not a range

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    0b111cb View commit details
    Browse the repository at this point in the history

  7. fix stale annotations in hook

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    9e134f5 View commit details
    Browse the repository at this point in the history

  8. Add general comments without anchors above all other comments

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    75ae3f8 View commit details
    Browse the repository at this point in the history

  9. fix boundary check

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    4786d1b View commit details
    Browse the repository at this point in the history

  10. don't render duplicate hightlight + added annotation when commenting … 

    …on edits
    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    106e638 View commit details
    Browse the repository at this point in the history

  11. allow to use markdown in comments

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    b47da99 View commit details
    Browse the repository at this point in the history

  12. Render markdown comments

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    a070345 View commit details
    Browse the repository at this point in the history

  13. support images in comments

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    b30c27c View commit details
    Browse the repository at this point in the history

  14. WIP: add back inline comments for tee

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    56d3f1a View commit details
    Browse the repository at this point in the history

  15. hide inline comments when sidebar is open

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    9cd72f4 View commit details
    Browse the repository at this point in the history

  16. tweak styling

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    51a117f View commit details
    Browse the repository at this point in the history

  17. handle hover state

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    4952249 View commit details
    Browse the repository at this point in the history

  18. tweak styling

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    7b1f509 View commit details
    Browse the repository at this point in the history

  19. move resolve logic into AnnotationGroupView

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    c424a0b View commit details
    Browse the repository at this point in the history

  20. allow to edit own comments

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    777765a View commit details
    Browse the repository at this point in the history

  21. fix click handler

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    405180f View commit details
    Browse the repository at this point in the history

  22. hoist up comment edit state to VersionControlEditor

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    81e67da View commit details
    Browse the repository at this point in the history

  23. Allow to reply to comments

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    b0ddc33 View commit details
    Browse the repository at this point in the history

  24. Add comment button

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    e3fffce View commit details
    Browse the repository at this point in the history

  25. create pending discussion group when comment is added on new range

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    f8eaf77 View commit details
    Browse the repository at this point in the history

  26. hide comment button if editor is not focused

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    cf8ed43 View commit details
    Browse the repository at this point in the history

  27. allow to comment on end of document

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    d6eeee5 View commit details
    Browse the repository at this point in the history

  28. Add comment button in sidebar

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    82cf2fc View commit details
    Browse the repository at this point in the history

  29. replace edit/create comment with setCommentState

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    70523cb View commit details
    Browse the repository at this point in the history

  30. fix global comments

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    737980a View commit details
    Browse the repository at this point in the history

  31. stop navigation key presses from bubbling up

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    de2b382 View commit details
    Browse the repository at this point in the history

  32. Fix adding replies

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    dfd480c View commit details
    Browse the repository at this point in the history

  33. fix keyboard shortcuts

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    29a8a91 View commit details
    Browse the repository at this point in the history

  34. fix filter out resolved discussions

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    ea5d72d View commit details
    Browse the repository at this point in the history

  35. adjust estimatedHeightOfAnnotationGroups function

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    8f78944 View commit details
    Browse the repository at this point in the history

  36. tweak styling

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    df233ba View commit details
    Browse the repository at this point in the history

  37. codemirror: avoid triggering redundant events 

    ensure codemirror only triggers selectedAnchor changes if the selection changed
    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    f7bb647 View commit details
    Browse the repository at this point in the history

  38. fix global add coment keyboard shortcut

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    ed5ca1f View commit details
    Browse the repository at this point in the history

  39. show comments without anchors always on top

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    d925c55 View commit details
    Browse the repository at this point in the history

  40. render whitespaces in essay annotations correctly

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    9c45b6f View commit details
    Browse the repository at this point in the history

  41. fix commenting on edits

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    555fa18 View commit details
    Browse the repository at this point in the history

  42. don't filter out annotations at beginning of text

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    f69dd01 View commit details
    Browse the repository at this point in the history

  43. cleanup higlight renders in EssayAnnotations view

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    5771f6d View commit details
    Browse the repository at this point in the history

  44. fix side by side

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    a8500a2 View commit details
    Browse the repository at this point in the history

  45. only highlight sidebar button for datatypes without inline comments

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    b518caf View commit details
    Browse the repository at this point in the history

  46. fix type errors

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    7b1225e View commit details
    Browse the repository at this point in the history

  47. fix view branch button

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    50e224b View commit details
    Browse the repository at this point in the history

  48. fix accesing property on undefined

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    e05e2d5 View commit details
    Browse the repository at this point in the history

  49. add naive invert 

    - add invert patches to annotations
    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    68c605c View commit details
    Browse the repository at this point in the history

  50. normalize redundant patches in essay

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    a7609b9 View commit details
    Browse the repository at this point in the history

  51. fix offset bugs

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    5665824 View commit details
    Browse the repository at this point in the history

  52. When normalizing an insert followed by a delete try to display it as … 

    …a full word replacement
    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    2c8261c View commit details
    Browse the repository at this point in the history

  53. handle complete overlaps correctly

    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    3ac26c5 View commit details
    Browse the repository at this point in the history

  54. try to create full word replacements when normalizing changes with ov… 

    …erlap end
    @paulsonnentag
    paulsonnentag committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    0e87a82 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Simplify diff normalization

    @paulsonnentag
    paulsonnentag committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    dd1e822 View commit details
    Browse the repository at this point in the history

  2. do a content based diff on subsequent insert delete patches

    @paulsonnentag
    paulsonnentag committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    2aa300b View commit details
    Browse the repository at this point in the history

  3. add inverse patches to replace

    @paulsonnentag
    paulsonnentag committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c0b027c View commit details
    Browse the repository at this point in the history

  4. combine words

    @paulsonnentag
    paulsonnentag committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    f684683 View commit details
    Browse the repository at this point in the history

  5. make patches relative

    @paulsonnentag
    paulsonnentag committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    5d92a28 View commit details
    Browse the repository at this point in the history