Skip to content

Commit

Permalink
windows: properly test against Python version string
Browse files Browse the repository at this point in the history
The value passed in here is `XY` not `X.Y`. That means that our
`pathcch` and `shlwapi` annotations were incorrect prior to this
change.

This fixes bugs in the following commits:

* 9fb81f1
* cc9da9c
* 4ff995a
  • Loading branch information
indygreg committed Feb 27, 2022
1 parent a804c18 commit 9de5fd3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cpython-windows/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -1876,11 +1876,11 @@ def find_additional_dependencies(project: pathlib.Path):
]

# pathcch is required on 3.9+ and its presence drops support for Windows 7.
if python_majmin != "3.8":
if python_majmin != "38":
res["core"]["links"].append({"name": "pathcch", "system": True})

# shlwapi was dropped from 3.9.9+.
if python_majmin == "3.8":
if python_majmin == "38":
res["core"]["links"].append({"name": "shlwapi", "system": True})

# Copy files for extensions into their own directories.
Expand Down

0 comments on commit 9de5fd3

Please sign in to comment.