Array: use np.result_type directly #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This probably needs a bit more testing, but what do you think of the idea @inducer? |
inducer
reviewed
Oct 2, 2024
|
|
||
| o1_key = obj1 if o1_is_integral and not o1_is_array else o1_dtype | ||
| o2_key = obj2 if o2_is_integral and not o2_is_array else o2_dtype | ||
| result = np.result_type(obj1, obj2) |
There was a problem hiding this comment.
Add a comment (like the one in pytato) that we're passing pyopencl arrays to numpy, and that it doesn't seem to mind. Maybe add an analogous test.
There was a problem hiding this comment.
Added in 5f668e2
alexfikl
reviewed
Oct 3, 2024
matthiasdiener
force-pushed
the
array-dtype
branch
from
0c37b58
to
7c4ddfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to inducer/pytato#540
Please squash