Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to demonstrate simplex integral fails with overintegration #364

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add test to demonstrate simplex integral fails with overintegration #364

wants to merge 5 commits into from

Conversation

MTCam
Copy link
Collaborator

@MTCam MTCam commented Sep 25, 2024 •
edited
Loading

This fixes a hang-up with previous implementation of the integral and elementewise_integral utils when using simplices with overintegration, and adds TPEs to the suite of tested mesh cases in the surface area test.

  • Adds TPE mesh to tested cases in test_mass_surface_area
  • Switches integral and elementwise_integral to use quadrature weights directly instead of _apply_mass_matrix to get the weights

Fixes: #365

@MTCam MTCam mentioned this pull request Sep 25, 2024
Open
@MTCam MTCam marked this pull request as ready for review September 27, 2024 17:51
@MTCam MTCam requested a review from inducer September 27, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inducer inducer Awaiting requested review from inducer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

integrals do not work for simplices when overintegrating
1 participant
@MTCam