-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Add protocol versions to "About UniMe" page #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiertech
changed the title
Add underlying specs to "About UniMe" page
chore: Add underlying specs to "About UniMe" page
Jul 4, 2024
maiertech
changed the title
chore: Add underlying specs to "About UniMe" page
refactor: Add underlying specs to "About UniMe" page
Jul 4, 2024
Display in dev mode only. |
maiertech
force-pushed
the
maiertech/issue265
branch
from
July 24, 2024 16:13
f35e885
to
ba55a3d
Compare
nanderstabel
previously approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The WebKit issue I encountered is related to my VSCode somehow. After following these instructions the problem was resolved for me. |
nanderstabel
previously approved these changes
Jul 29, 2024
daniel-mader
approved these changes
Jul 29, 2024
nanderstabel
approved these changes
Jul 29, 2024
maiertech
changed the title
refactor: Add underlying specs to "About UniMe" page
refactor: Add protocol versions to "About UniMe" page
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
List the specs and their versions used in UniMe's about page but only in dev mode.
Links to any relevant issues
Fixes #265.
How the change has been tested
Visual check of the "About UniMe" page (turn dev mode on and off).
Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.