「フィルターされました」表示を非表示に変更 #211
Open
+1
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnanase
added
enhancement
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #187
少し迷ったのですが、このPRでは無条件で非表示にしています。
本家でも議論されているように、accountに表示するかどうかのフラグを設けるとか、
色々あると思いますが、私個人ではこのフィルターの表示は必要ないと思っています。
アイマストドンくらいの大規模インスタンスだと、
この修正で不具合が起こる可能性も考えられますので、
お手数ですがご確認をお願いしたく、よろしくお願い致します。