-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add export option for single-scale OME-Zarr #316
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
==========================================
- Coverage 36.58% 36.48% -0.10%
==========================================
Files 108 107 -1
Lines 11489 11371 -118
==========================================
- Hits 4203 4149 -54
+ Misses 7286 7222 -64 ☔ View full report in Codecov by Sentry. |
4ce7d73
to
f2dea57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, nice refactor, too :) great to unify those things :). And less code, more functionality - you seem to have a knack for that 👍
Could've been rebased onto main before opening... (I thought darkmode was broken again...)
Get rid of unintuitive extensions without leading .
dec2e97
to
5292923
Compare
Ready to merge when ilastik PR is done |
Instead of adding a triplicate of the H5/N5 file options widget, I figured I'd combine them instead. Still pondering whether the one point of custom logic for zarr (allowing dataset to be empty) warrants a duplicate, but don't really think so. Not sure why it's mandatory anyway; there is ilastik code that enforces an internal path to be present for H5 but not N5.
I've put the menu option under the below hierarchical formats for now, but that's easy to relocate if we want to have it further up or down the list.