Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optional dependencies for pip<21.2 #7

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Fix optional dependencies for pip<21.2 #7

merged 2 commits into from
Nov 14, 2023

Conversation

lreiher
Copy link
Member

@lreiher lreiher commented Nov 14, 2023

  • pip supports recursive optional dependencies in pyproject.toml starting with v21.2 (source)
  • the change explicitly sets optional dependencies for now
  • this fixes, e.g., pip install docker-run-cli[plugins] on pip<21.2

@lreiher lreiher requested a review from jpbusch November 14, 2023 08:33
@jpbusch jpbusch merged commit a4a0d92 into main Nov 14, 2023
2 checks passed
@jpbusch jpbusch deleted the fix/optional-deps-pip branch November 14, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbusch jpbusch jpbusch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lreiher @jpbusch