Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-system to FEProblemSolve and deploy on Physics syntax #29021

Open
wants to merge 23 commits into
base: next
Choose a base branch
from
Open

Add multi-system to FEProblemSolve and deploy on Physics syntax #29021

wants to merge 23 commits into from
+1,746 −453

Commits on Nov 13, 2024

  1. Add support for multi-system at the Physics base class refs idaholab#… 

    …8780 idaholab#29019
    @GiudGiud
    GiudGiud committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    af40fae View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Enable multi-system in derived physics in MOOSE

    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    285d84e View commit details
    Browse the repository at this point in the history

  2. Add a new solve object for solves with multiple systems

    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    9699d9c View commit details
    Browse the repository at this point in the history

  3. Add support for multiple nonlinear cv objects for mnultisys for defau… 

    …lt cv behavior
    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    e72660a View commit details
    Browse the repository at this point in the history

  4. Add multi-nonlinear system support to FEProblemSolve

    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    a5c8c3d View commit details
    Browse the repository at this point in the history

  5. Add support for multi-nonlinear systems residual debugging

    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    2dea80d View commit details
    Browse the repository at this point in the history

  6. Offer option to solve for dynamic pressure from the Physics

    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    8025c43 View commit details
    Browse the repository at this point in the history

  7. Evaluate fluid properties using the total pressure

    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    75a6931 View commit details
    Browse the repository at this point in the history

  8. Add test for using the dynamic pressure

    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    7ff7654 View commit details
    Browse the repository at this point in the history

  9. Add a test for picard multi-system 

    refs idaholab#8780
    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    0b8469e View commit details
    Browse the repository at this point in the history

  10. Add testing for multi-system + physics

    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    717e6ad View commit details
    Browse the repository at this point in the history

  11. Improve classic multi-system error message 

    Add documentation for multi-system fixed point
    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    9e88367 View commit details
    Browse the repository at this point in the history

  12. Adress Josh s review 

    - more careful distinction between linear and nonlinear systems
- fix error messages

Co-authored-by: joshuahansel <[email protected]>
    @GiudGiud @joshuahansel
    GiudGiud and joshuahansel committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    65345cb View commit details
    Browse the repository at this point in the history

  13. Make framework tests pass: 

    - remove extra space on Solve  converged
- check for the existence of a single default NL conv
- make the minimalApp test more resilient to ordering of object creation
    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b5f7713 View commit details
    Browse the repository at this point in the history

  14. Skip RC UO execution on addition NL systems

    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    7d81213 View commit details
    Browse the repository at this point in the history

  15. Fix multi-system restart from physics

    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    539d538 View commit details
    Browse the repository at this point in the history

  16. Add additional API to facilitate getting the system number from the v… 

    …ariable name

Re-order tasks to make adding variables before checking integrity in physics (checks variables & systems)
Add missing required tasks
    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    c1ad9b8 View commit details
    Browse the repository at this point in the history

  17. Allow 1D full-dimensional elements in a 2D mesh for projections

    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    579c9a3 View commit details
    Browse the repository at this point in the history

  18. Add legacy single-system behavior back to allow Optim modules executi… 

    …oners to function

They rely on solving only one system, then performing operations in their OTHER solveObject (not fixed point solve, not inner_solve)
then solving the second one
    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    4368c4d View commit details
    Browse the repository at this point in the history

  19. Add parameter groups, improve logic when using legacy single-system b… 

    …ehavior
    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    1832e14 View commit details
    Browse the repository at this point in the history

  20. Add another error to cover wrong size for vector params

    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    2d84669 View commit details
    Browse the repository at this point in the history

  21. Add more exception testing

    @GiudGiud
    GiudGiud committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    8f0ff16 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Address Alex's review 

    - remove boolean that enables legacy behavior
- rename a parameter and re-type it to forward the selection of forward solve to the list of nonlinear systesm

Co-authored-by: Alex Lindsay <[email protected]>
    @GiudGiud @lindsayad
    GiudGiud and lindsayad committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    2484bd4 View commit details
    Browse the repository at this point in the history