Add shared library version (make and cmake) #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for function in 1st argument of ifneq causes error; seems like GNU make bug. Move it to 2nd argument.
…LDFLAGS, LIBS into rule-specific LDFLAGS, LIBS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds shared library soversion in Makefile and CMake. See related PR in TestSweeeper (icl-utk-edu/testsweeper#23). Also in BLAS++ (icl-utk-edu/blaspp#83) and LAPACK++ (icl-utk-edu/lapackpp#59).
Also cleans up Makefile. See icl-utk-edu/testsweeper#25 and icl-utk-edu/testsweeper#26.
Fixes a couple issues with the
unit_test/test_norm. Therun_tests.pyscript setCUDA_VISIBLE_DEVICESand wasn't restoring it, sotest_normdidn't see GPUs. Then found some LAPACK versions are not accurate for large matrices, so use smaller test matrix. (Sorry, unrelated to shared library version.)