Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rapl: Added RAPL component support for Intel RaptorLake. #244

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

willowec
Copy link
Contributor

@willowec willowec commented Sep 19, 2024

Pull Request Description

This PR adds support for the rapl component on Intel's RaptorLake architecture. Adding this was extremely simple as RaptorLake has the same RAPL setup as SandyBridge and IvyBridge.

Tested systems:

System Name Family/Model/Stepping papi_native_avail papi_component_avail papi_command_line RAPL tests
Raptor Lake-S/HX B0 0x6/0xb7/0x1

Author Checklist

  • Description
    Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
  • Commits
    Commits are self contained and only do one thing
    Commits have a header of the form: module: short description
    Commits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
  • Tests
    The PR needs to pass all the tests

@Treece-Burgess
Copy link
Contributor

@willowec How many different CPU's in the Intel RaptorLake family were you able to test on for this change and what exactly did you test?

It would be good if you could test multiple different CPU's in the Intel RaptorLake family and after building the RAPL component, running the utilities: papi_native_avail, papi_component_avail, and papi_command_line to make sure you get the expected results. As well as the tests in rapl/tests/. See PR #275 for how I went about testing to add support for AMD family 25.

@willowec
Copy link
Contributor Author

@Treece-Burgess I've added the table of tests that I have run, but I only have access to one of the three varieties of RaptorLake machines. I'm glad you pointed this out though, because I when I created this PR I did not know that multiple varieties existed. Would you like me to add the other two varieties without testing them?

@Treece-Burgess
Copy link
Contributor

@willowec If you could add the other two varieties that would be great! Two other comments:

  1. Could you order the cases' in ascending order? E.g.:
case 42:
case 58:
case 183:
...
  1. In your commit message can you add which RaptorLake's you were able to test on (including the Family/Model/Stepping) and which you were not able to test on (does not need to include the Family/Model/Stepping)? Such that we can use this as a reference later if needed.

willowec and others added 3 commits November 14, 2024 12:08
Add RAPL component support for the RaptorLake architecture. This change
was tested for Family/Model/Stepping 0x6/0xb7/0x1 (RaptorLake-S/HX) only.
The other two models of RaptorLake (Models 0xba and 0xbf) are untested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants