Don't copy data in for output variables: to_lapack_int can throw on u…

…ninitialized data. Update generator script.
icl-utk-edu · Oct 24, 2024 · 7c6aecd · 7c6aecd
1 parent bd42886
commit 7c6aecd
Show file tree

Hide file tree

Showing 46 changed files with 373 additions and 359 deletions.
diff --git a/src/bdsvdx.cc b/src/bdsvdx.cc
@@ -8,7 +8,7 @@
 #include "lapack/fortran.h"
 #include "NoConstructAllocator.hh"
 
-#if LAPACK_VERSION >= 30600  // >= v3.6
+#if LAPACK_VERSION >= 30600  // >= 3.6.0
 
 #include <vector>
 
@@ -34,7 +34,7 @@ int64_t bdsvdx(
     lapack_int n_ = to_lapack_int( n );
     lapack_int il_ = to_lapack_int( il );
     lapack_int iu_ = to_lapack_int( iu );
-    lapack_int nfound_ = to_lapack_int( *nfound );
+    lapack_int nfound_ = 0;
     lapack_int ldz_ = to_lapack_int( ldz );
     lapack_int info_ = 0;
 
@@ -202,7 +202,7 @@ int64_t bdsvdx(
     lapack_int n_ = to_lapack_int( n );
     lapack_int il_ = to_lapack_int( il );
     lapack_int iu_ = to_lapack_int( iu );
-    lapack_int nfound_ = to_lapack_int( *nfound );
+    lapack_int nfound_ = 0;
     lapack_int ldz_ = to_lapack_int( ldz );
     lapack_int info_ = 0;
 
@@ -228,4 +228,4 @@ int64_t bdsvdx(
 
 }  // namespace lapack
 
-#endif  // LAPACK >= v3.6
+#endif  // LAPACK >= 3.6.0
diff --git a/src/gebal.cc b/src/gebal.cc
@@ -27,8 +27,8 @@ int64_t gebal(
     char balance_ = to_char( balance );
     lapack_int n_ = to_lapack_int( n );
     lapack_int lda_ = to_lapack_int( lda );
-    lapack_int ilo_ = to_lapack_int( *ilo );
-    lapack_int ihi_ = to_lapack_int( *ihi );
+    lapack_int ilo_ = 0;
+    lapack_int ihi_ = 0;
     lapack_int info_ = 0;
 
     LAPACK_sgebal(
@@ -56,8 +56,8 @@ int64_t gebal(
     char balance_ = to_char( balance );
     lapack_int n_ = to_lapack_int( n );
     lapack_int lda_ = to_lapack_int( lda );
-    lapack_int ilo_ = to_lapack_int( *ilo );
-    lapack_int ihi_ = to_lapack_int( *ihi );
+    lapack_int ilo_ = 0;
+    lapack_int ihi_ = 0;
     lapack_int info_ = 0;
 
     LAPACK_dgebal(
@@ -85,8 +85,8 @@ int64_t gebal(
     char balance_ = to_char( balance );
     lapack_int n_ = to_lapack_int( n );
     lapack_int lda_ = to_lapack_int( lda );
-    lapack_int ilo_ = to_lapack_int( *ilo );
-    lapack_int ihi_ = to_lapack_int( *ihi );
+    lapack_int ilo_ = 0;
+    lapack_int ihi_ = 0;
     lapack_int info_ = 0;
 
     LAPACK_cgebal(
@@ -203,8 +203,8 @@ int64_t gebal(
     char balance_ = to_char( balance );
     lapack_int n_ = to_lapack_int( n );
     lapack_int lda_ = to_lapack_int( lda );
-    lapack_int ilo_ = to_lapack_int( *ilo );
-    lapack_int ihi_ = to_lapack_int( *ihi );
+    lapack_int ilo_ = 0;
+    lapack_int ihi_ = 0;
     lapack_int info_ = 0;
 
     LAPACK_zgebal(

diff --git a/src/gees.cc b/src/gees.cc
@@ -28,7 +28,7 @@ int64_t gees(
     char sort_ = to_char( sort );
     lapack_int n_ = to_lapack_int( n );
     lapack_int lda_ = to_lapack_int( lda );
-    lapack_int sdim_ = to_lapack_int( *sdim );
+    lapack_int sdim_ = 0;
     lapack_int ldvs_ = to_lapack_int( ldvs );
     lapack_int info_ = 0;
 
@@ -214,7 +214,7 @@ int64_t gees(
     char sort_ = to_char( sort );
     lapack_int n_ = to_lapack_int( n );
     lapack_int lda_ = to_lapack_int( lda );
-    lapack_int sdim_ = to_lapack_int( *sdim );
+    lapack_int sdim_ = 0;
     lapack_int ldvs_ = to_lapack_int( ldvs );
     lapack_int info_ = 0;
 

diff --git a/src/geesx.cc b/src/geesx.cc
@@ -31,7 +31,7 @@ int64_t geesx(
     char sense_ = to_char( sense );
     lapack_int n_ = to_lapack_int( n );
     lapack_int lda_ = to_lapack_int( lda );
-    lapack_int sdim_ = to_lapack_int( *sdim );
+    lapack_int sdim_ = 0;
     lapack_int ldvs_ = to_lapack_int( ldvs );
     lapack_int info_ = 0;
 
@@ -103,7 +103,7 @@ int64_t geesx(
     char sense_ = to_char( sense );
     lapack_int n_ = to_lapack_int( n );
     lapack_int lda_ = to_lapack_int( lda );
-    lapack_int sdim_ = to_lapack_int( *sdim );
+    lapack_int sdim_ = 0;
     lapack_int ldvs_ = to_lapack_int( ldvs );
     lapack_int info_ = 0;
 
@@ -175,7 +175,7 @@ int64_t geesx(
     char sense_ = to_char( sense );
     lapack_int n_ = to_lapack_int( n );
     lapack_int lda_ = to_lapack_int( lda );
-    lapack_int sdim_ = to_lapack_int( *sdim );
+    lapack_int sdim_ = 0;
     lapack_int ldvs_ = to_lapack_int( ldvs );
     lapack_int info_ = 0;
 
@@ -236,7 +236,7 @@ int64_t geesx(
     char sense_ = to_char( sense );
     lapack_int n_ = to_lapack_int( n );
     lapack_int lda_ = to_lapack_int( lda );
-    lapack_int sdim_ = to_lapack_int( *sdim );
+    lapack_int sdim_ = 0;
     lapack_int ldvs_ = to_lapack_int( ldvs );
     lapack_int info_ = 0;
 

diff --git a/src/gelsd.cc b/src/gelsd.cc
@@ -30,7 +30,7 @@ int64_t gelsd(
     lapack_int nrhs_ = to_lapack_int( nrhs );
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int ldb_ = to_lapack_int( ldb );
-    lapack_int rank_ = to_lapack_int( *rank );
+    lapack_int rank_ = 0;
     lapack_int info_ = 0;
 
     // query for workspace size
@@ -82,7 +82,7 @@ int64_t gelsd(
     lapack_int nrhs_ = to_lapack_int( nrhs );
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int ldb_ = to_lapack_int( ldb );
-    lapack_int rank_ = to_lapack_int( *rank );
+    lapack_int rank_ = 0;
     lapack_int info_ = 0;
 
     // query for workspace size
@@ -134,7 +134,7 @@ int64_t gelsd(
     lapack_int nrhs_ = to_lapack_int( nrhs );
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int ldb_ = to_lapack_int( ldb );
-    lapack_int rank_ = to_lapack_int( *rank );
+    lapack_int rank_ = 0;
     lapack_int info_ = 0;
 
     // query for workspace size
@@ -272,7 +272,7 @@ int64_t gelsd(
     lapack_int nrhs_ = to_lapack_int( nrhs );
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int ldb_ = to_lapack_int( ldb );
-    lapack_int rank_ = to_lapack_int( *rank );
+    lapack_int rank_ = 0;
     lapack_int info_ = 0;
 
     // query for workspace size

diff --git a/src/gelss.cc b/src/gelss.cc
@@ -30,7 +30,7 @@ int64_t gelss(
     lapack_int nrhs_ = to_lapack_int( nrhs );
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int ldb_ = to_lapack_int( ldb );
-    lapack_int rank_ = to_lapack_int( *rank );
+    lapack_int rank_ = 0;
     lapack_int info_ = 0;
 
     // query for workspace size
@@ -77,7 +77,7 @@ int64_t gelss(
     lapack_int nrhs_ = to_lapack_int( nrhs );
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int ldb_ = to_lapack_int( ldb );
-    lapack_int rank_ = to_lapack_int( *rank );
+    lapack_int rank_ = 0;
     lapack_int info_ = 0;
 
     // query for workspace size
@@ -124,7 +124,7 @@ int64_t gelss(
     lapack_int nrhs_ = to_lapack_int( nrhs );
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int ldb_ = to_lapack_int( ldb );
-    lapack_int rank_ = to_lapack_int( *rank );
+    lapack_int rank_ = 0;
     lapack_int info_ = 0;
 
     // query for workspace size
@@ -242,7 +242,7 @@ int64_t gelss(
     lapack_int nrhs_ = to_lapack_int( nrhs );
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int ldb_ = to_lapack_int( ldb );
-    lapack_int rank_ = to_lapack_int( *rank );
+    lapack_int rank_ = 0;
     lapack_int info_ = 0;
 
     // query for workspace size

diff --git a/src/gelsy.cc b/src/gelsy.cc
@@ -37,7 +37,7 @@ int64_t gelsy(
     #else
         lapack_int* jpvt_ptr = jpvt;
     #endif
-    lapack_int rank_ = to_lapack_int( *rank );
+    lapack_int rank_ = 0;
     lapack_int info_ = 0;
 
     // query for workspace size
@@ -94,7 +94,7 @@ int64_t gelsy(
     #else
         lapack_int* jpvt_ptr = jpvt;
     #endif
-    lapack_int rank_ = to_lapack_int( *rank );
+    lapack_int rank_ = 0;
     lapack_int info_ = 0;
 
     // query for workspace size
@@ -151,7 +151,7 @@ int64_t gelsy(
     #else
         lapack_int* jpvt_ptr = jpvt;
     #endif
-    lapack_int rank_ = to_lapack_int( *rank );
+    lapack_int rank_ = 0;
     lapack_int info_ = 0;
 
     // query for workspace size
@@ -311,7 +311,7 @@ int64_t gelsy(
     #else
         lapack_int* jpvt_ptr = jpvt;
     #endif
-    lapack_int rank_ = to_lapack_int( *rank );
+    lapack_int rank_ = 0;
     lapack_int info_ = 0;
 
     // query for workspace size

diff --git a/src/gesv.cc b/src/gesv.cc
@@ -226,7 +226,7 @@ int64_t gesv(
     #endif
     lapack_int ldb_ = to_lapack_int( ldb );
     lapack_int ldx_ = to_lapack_int( ldx );
-    lapack_int iter_ = to_lapack_int( *iter );
+    lapack_int iter_ = 0;
     lapack_int info_ = 0;
 
     // allocate workspace
@@ -272,7 +272,7 @@ int64_t gesv(
     #endif
     lapack_int ldb_ = to_lapack_int( ldb );
     lapack_int ldx_ = to_lapack_int( ldx );
-    lapack_int iter_ = to_lapack_int( *iter );
+    lapack_int iter_ = 0;
     lapack_int info_ = 0;
 
     // allocate workspace

diff --git a/src/gesvdx.cc b/src/gesvdx.cc
@@ -8,7 +8,7 @@
 #include "lapack/fortran.h"
 #include "NoConstructAllocator.hh"
 
-#if LAPACK_VERSION >= 30600  // >= v3.6
+#if LAPACK_VERSION >= 30600  // >= 3.6.0
 
 #include <vector>
 
@@ -36,7 +36,7 @@ int64_t gesvdx(
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int il_ = to_lapack_int( il );
     lapack_int iu_ = to_lapack_int( iu );
-    lapack_int nfound_ = to_lapack_int( *nfound );
+    lapack_int nfound_ = 0;
     lapack_int ldu_ = to_lapack_int( ldu );
     lapack_int ldvt_ = to_lapack_int( ldvt );
     lapack_int info_ = 0;
@@ -97,7 +97,7 @@ int64_t gesvdx(
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int il_ = to_lapack_int( il );
     lapack_int iu_ = to_lapack_int( iu );
-    lapack_int nfound_ = to_lapack_int( *nfound );
+    lapack_int nfound_ = 0;
     lapack_int ldu_ = to_lapack_int( ldu );
     lapack_int ldvt_ = to_lapack_int( ldvt );
     lapack_int info_ = 0;
@@ -158,7 +158,7 @@ int64_t gesvdx(
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int il_ = to_lapack_int( il );
     lapack_int iu_ = to_lapack_int( iu );
-    lapack_int nfound_ = to_lapack_int( *nfound );
+    lapack_int nfound_ = 0;
     lapack_int ldu_ = to_lapack_int( ldu );
     lapack_int ldvt_ = to_lapack_int( ldvt );
     lapack_int info_ = 0;
@@ -353,7 +353,7 @@ int64_t gesvdx(
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int il_ = to_lapack_int( il );
     lapack_int iu_ = to_lapack_int( iu );
-    lapack_int nfound_ = to_lapack_int( *nfound );
+    lapack_int nfound_ = 0;
     lapack_int ldu_ = to_lapack_int( ldu );
     lapack_int ldvt_ = to_lapack_int( ldvt );
     lapack_int info_ = 0;
@@ -405,4 +405,4 @@ int64_t gesvdx(
 
 }  // namespace lapack
 
-#endif  // LAPACK >= v3.6
+#endif  // LAPACK >= 3.6.0
diff --git a/src/ggbal.cc b/src/ggbal.cc
@@ -30,8 +30,8 @@ int64_t ggbal(
     lapack_int n_ = to_lapack_int( n );
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int ldb_ = to_lapack_int( ldb );
-    lapack_int ilo_ = to_lapack_int( *ilo );
-    lapack_int ihi_ = to_lapack_int( *ihi );
+    lapack_int ilo_ = 0;
+    lapack_int ihi_ = 0;
     lapack_int info_ = 0;
 
     // from docs
@@ -70,8 +70,8 @@ int64_t ggbal(
     lapack_int n_ = to_lapack_int( n );
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int ldb_ = to_lapack_int( ldb );
-    lapack_int ilo_ = to_lapack_int( *ilo );
-    lapack_int ihi_ = to_lapack_int( *ihi );
+    lapack_int ilo_ = 0;
+    lapack_int ihi_ = 0;
     lapack_int info_ = 0;
 
     // from docs
@@ -110,8 +110,8 @@ int64_t ggbal(
     lapack_int n_ = to_lapack_int( n );
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int ldb_ = to_lapack_int( ldb );
-    lapack_int ilo_ = to_lapack_int( *ilo );
-    lapack_int ihi_ = to_lapack_int( *ihi );
+    lapack_int ilo_ = 0;
+    lapack_int ihi_ = 0;
     lapack_int info_ = 0;
 
     // from docs
@@ -150,8 +150,8 @@ int64_t ggbal(
     lapack_int n_ = to_lapack_int( n );
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int ldb_ = to_lapack_int( ldb );
-    lapack_int ilo_ = to_lapack_int( *ilo );
-    lapack_int ihi_ = to_lapack_int( *ihi );
+    lapack_int ilo_ = 0;
+    lapack_int ihi_ = 0;
     lapack_int info_ = 0;
 
     // from docs

diff --git a/src/gges.cc b/src/gges.cc
@@ -34,7 +34,7 @@ int64_t gges(
     lapack_int n_ = to_lapack_int( n );
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int ldb_ = to_lapack_int( ldb );
-    lapack_int sdim_ = to_lapack_int( *sdim );
+    lapack_int sdim_ = 0;
     lapack_int ldvsl_ = to_lapack_int( ldvsl );
     lapack_int ldvsr_ = to_lapack_int( ldvsr );
     lapack_int info_ = 0;
@@ -111,7 +111,7 @@ int64_t gges(
     lapack_int n_ = to_lapack_int( n );
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int ldb_ = to_lapack_int( ldb );
-    lapack_int sdim_ = to_lapack_int( *sdim );
+    lapack_int sdim_ = 0;
     lapack_int ldvsl_ = to_lapack_int( ldvsl );
     lapack_int ldvsr_ = to_lapack_int( ldvsr );
     lapack_int info_ = 0;
@@ -188,7 +188,7 @@ int64_t gges(
     lapack_int n_ = to_lapack_int( n );
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int ldb_ = to_lapack_int( ldb );
-    lapack_int sdim_ = to_lapack_int( *sdim );
+    lapack_int sdim_ = 0;
     lapack_int ldvsl_ = to_lapack_int( ldvsl );
     lapack_int ldvsr_ = to_lapack_int( ldvsr );
     lapack_int info_ = 0;
@@ -259,7 +259,7 @@ int64_t gges(
     lapack_int n_ = to_lapack_int( n );
     lapack_int lda_ = to_lapack_int( lda );
     lapack_int ldb_ = to_lapack_int( ldb );
-    lapack_int sdim_ = to_lapack_int( *sdim );
+    lapack_int sdim_ = 0;
     lapack_int ldvsl_ = to_lapack_int( ldvsl );
     lapack_int ldvsr_ = to_lapack_int( ldvsr );
     lapack_int info_ = 0;