Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Tensorflow 2.17 #11

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Support for Tensorflow 2.17 #11

wants to merge 2 commits into from

Conversation

mhuen
Copy link
Collaborator

@mhuen mhuen commented Oct 22, 2024

Adds support for newest tensorflow version. This PR includes two updates:

  • Convert KerasVariable to tensor
  • fix eager execution for LR scheduler

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@f2d0832). Learn more about missing BASE report.

Files with missing lines Patch % Lines
dnn_reco/model.py 0.00% 5 Missing ⚠️
dnn_reco/utils/learning_rate.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             master     #11   +/-   ##
========================================
  Coverage          ?   4.61%           
========================================
  Files             ?      32           
  Lines             ?    2926           
  Branches          ?     509           
========================================
  Hits              ?     135           
  Misses            ?    2790           
  Partials          ?       1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhuen mhuen marked this pull request as draft October 23, 2024 18:39
@mhuen
Copy link
Collaborator Author

mhuen commented Oct 23, 2024

Note: while falling back to compat.v1 optimizers works, support for variable learning rates is lost that was previously available. The issue is that newer tensorflow optimizers utilize keras optimizers which do not return the update operation when calling the apply_gradients method.
A proper solution is to convert everything to TF2 instead of relying on tf.compat.v1 symbols. See also #7 . This requires and extensive rewrite though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants