Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the permissions controller is displayed if the camera permi… #142

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

onato
Copy link

@onato onato commented Feb 26, 2019

…ssions are not determined. #141

Possible something similar should be done with Photos permissions. Should we really show the permissions controller if the user has said no to photos and yes to the camera?

@onato onato force-pushed the master branch 2 times, most recently from b80b0dc to 8787b2a Compare February 26, 2019 03:35
@neodave
Copy link

neodave commented Jul 12, 2019

We are having this issue crop up as well, would love the fix to be included

@neodave
Copy link

neodave commented Aug 1, 2019

The permissions controller fix is not working for me. You have your code below this line

let useCamera = Permission.Camera.needsPermission && Permission.Camera.status == .authorized

Which seems to make your code never return nil

if useCamera, Permission.Camera.status == .notDetermined {
return nil
}

@3lvis
Copy link
Collaborator

3lvis commented Oct 4, 2020

Added the showStatusBar separately.

What I hear from @neodave is that this proposed fix doesn't work. Any clues what might work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants