Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Egoistic funding #397

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

sophia1ch
Copy link
Contributor

Description:

This PR builds upon the changes introduced in hyperledger-labs/perun-eth-backend#45 by extending egoistic funding to cross-chain swaps in the eth-backend.

In this update, we introduce a map for each chain, designating whether a chain is considered egoistic or not. This distinction is crucial in determining the funding order for different chains, ensuring that egoistic chains are funded last.

channel/multi/funder.go Show resolved Hide resolved
channel/multi/funder.go Show resolved Hide resolved
client/proposal.go Show resolved Hide resolved
@sophia1ch sophia1ch marked this pull request as ready for review February 20, 2024 08:50
@cryptphil
Copy link
Member

cryptphil commented Feb 23, 2024

I think the protocol is to merge first to our fork before create a PR here, right?

No, in general, you always merge to the hyperledger org main and then only sync this fork on perun-network. @NhoxxKienn

@sophia1ch sophia1ch force-pushed the feat-egoistic-funding branch 5 times, most recently from 6494d03 to 5cc42b0 Compare February 27, 2024 13:16
…ssets.

feat(proposal): Add SetEgoisticChain and RemoveEgoisticChain to change egoistic funder map,
when it is known which assets need to be funded first.

Refactor: Put funding loop into seperate function. Add comments.
Signed-off-by: Sophia Koehler <[email protected]>
@sophia1ch sophia1ch requested a review from cryptphil March 7, 2024 08:50
@NhoxxKienn NhoxxKienn merged commit 3811fdb into hyperledger-labs:main Mar 12, 2024
6 checks passed
@NhoxxKienn NhoxxKienn deleted the feat-egoistic-funding branch March 12, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants