feat: ica router management in core apply
#4820
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…min field to allow deploy overrides and checks
…hod to retrive proxy admin data
…e an already existing proxy admi ncontract for deployments
…to xeno/warp-deploy-apply-ownership-fixes
…to xeno/warp-deploy-apply-ownership-fixes
…ents and admin proxy ownership transfer in warp apply
Co-authored-by: Paul Balaji <[email protected]>
… to core init command
…nfig defines owners fro the mailbox proxy admin adn ica router and use those values intead of the signer
…to xeno/warp-deploy-apply-ownership-fixes
…to xeno/warp-deploy-apply-ownership-fixes
…t defined on the type
…to xeno/core-deploy-apply-admin-proxy-ownership-fixes
…yperlane-xyz/hyperlane-monorepo into xeno/core-deploy-apply-admin-proxy-ownership-fixes
…r the mailbox contract
…admin proxy ownership code
…ly for core command testing
…to xeno/core-deploy-apply-admin-proxy-ownership-fixes
…to xeno/warp-deploy-apply-ownership-fixes
…yperlane-xyz/hyperlane-monorepo into xeno/core-deploy-apply-admin-proxy-ownership-fixes
…y + fixed transaction issue when having to send txs on remote chains
…github.com:hyperlane-xyz/hyperlane-monorepo into xeno/ica-router-management-update
xeno097
requested review from
jmrossy,
yorhodes,
ltyu and
paulbalaji
as code owners
🦋 Changeset detectedLatest commit: a072e66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
xeno097
changed the title
core applycore apply
…to xeno/core-deploy-apply-admin-proxy-ownership-fixes
…github.com:hyperlane-xyz/hyperlane-monorepo into xeno/ica-router-management-update
Base automatically changed from
xeno/core-deploy-apply-admin-proxy-ownership-fixes
to
main
November 8, 2024 00:26
…to xeno/ica-router-management-update
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4820 +/- ##
=======================================
Coverage 74.60% 74.60%
=======================================
Files 103 103
Lines 1516 1516
Branches 195 195
=======================================
Hits 1131 1131
Misses 364 364
Partials 21 21
|
…to xeno/ica-router-management-update
ltyu
reviewed
Nov 13, 2024
| const transactions: AnnotatedEV5Transaction[] = []; | ||
|
|
||
| const routesToUnenroll = Array.from( | ||
| difference( |
There was a problem hiding this comment.
i like this! didn't realize we polyfilled this
ltyu
reviewed
Nov 13, 2024
| const remoteTransactions: AnnotatedEV5Transaction[] = domainsToEnroll.map( | ||
| (domainId) => ({ | ||
| annotation: `Enrolling InterchainAccountRouter on domain ${this.domainId} on InterchainAccountRouter at ${expectedConfig[domainId].address} on domain ${domainId}`, | ||
| chainId: Number(this.multiProvider.getChainId(domainId)), |
There was a problem hiding this comment.
think this is no longer true due to #4798
There was a problem hiding this comment.
Good catch! Should probably use the new getEvmChainId method here
ltyu
reviewed
Nov 13, 2024
| const remoteTransactions: AnnotatedEV5Transaction[] = routesToUnenroll.map( | ||
| (domainId) => ({ | ||
| annotation: `Removing InterchainAccountRouter on domain ${this.domainId} from InterchainAccountRouter at ${actualConfig[domainId].address} on domain ${domainId}`, | ||
| chainId: Number(this.multiProvider.getChainId(domainId)), |
…to xeno/ica-router-management-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the required logic to enroll/unenroll ICAs between them when running
core applyDrive-by changes
EvmIcaReaderEvmCoreModuleto read the current chain ICA configEvmIcaRouterReaderRelated issues
core apply#4819Backward compatibility
Testing
Note