feat(contracts): ValueRouter #4814
Conversation
…#4729) ### Description - implements `_outbound` and `_inbound` internal amount transforms for use in scaling warp routes - simplify `HypNativeScaled` implementation ### Backward compatibility Yes ### Testing Existing HypNative Scaled Unit Tests
…4673) ### Description - fixes misuse of aggregation hook funds for relaying messages by making sure msg.value is adequate and refunding if excess. ### Drive-by changes - None ### Related issues - related to #3437 ### Backward compatibility No, needs new deployments of aggregationHooks ### Testing Unit
|
| gasLimit(_metadata, 0), | ||
| refundAddress(_metadata, msg.sender), |
There was a problem hiding this comment.
I dont understand the 0 and msg.sender here
this will also memcopy for every field iiuc
There was a problem hiding this comment.
these are just default values in case the specific part of the metadata is null
true but memcopy is cheap
There was a problem hiding this comment.
0 gas limit and msg.sender for refund address as defaults does not make sense to me
There was a problem hiding this comment.
what would you have in their place?
Description
transferRemoteinterface to send msg value from A to B agnostic or the hook/ism needed to do soDrive-by changes
Related issues
Backward compatibility
Yes
Testing
Unit