fix: write merkle & IGP hook addresses if created by core deploy #4607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbalaji
requested review from
tkporter,
Mo-Hussain,
yorhodes,
jmrossy and
ltyu
as code owners
|
paulbalaji
requested review from
xeno097
and removed request for
jmrossy,
yorhodes,
tkporter and
Mo-Hussain
xeno097
previously approved these changes
Oct 2, 2024
paulbalaji
changed the title
paulbalaji
force-pushed
the
pb/core-artifacts
branch
from
fa26752
to
36e8829
Compare
Signed-off-by: pbio <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4607 +/- ##
=======================================
Coverage 73.89% 73.89%
=======================================
Files 100 100
Lines 1421 1421
Branches 180 180
=======================================
Hits 1050 1050
Misses 350 350
Partials 21 21
|
Signed-off-by: pbio <[email protected]>
paulbalaji
force-pushed
the
pb/core-artifacts
branch
from
36e8829
to
d33d27a
Compare
xeno097
approved these changes
Oct 3, 2024
paulbalaji
commented
Oct 4, 2024
paulbalaji
added a commit
that referenced
this pull request
Oct 4, 2024
### Description original: there was a series of related problems that people are encountering with cli deploys where the merkleTreeHook is deployed but its address is not included in the artifacts. this PR was intended to bring parity with how infra does it, we can also update for now to only add the merkleTreeHook to the output to unblock the base problem people are having update: restricted to just `merkleTreeHook` and `interchainGasPaymaster` to provide MVP fix  ### Related issues hyperlane-xyz/hyperlane-registry#240 (comment) hyperlane-xyz/hyperlane-registry#236 (comment) hyperlane-xyz/hyperlane-registry#237 (comment) ### Backward compatibility yes ### Testing manual --------- Signed-off-by: pbio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
original:
there was a series of related problems that people are encountering with cli deploys where the merkleTreeHook is deployed but its address is not included in the artifacts. this PR was intended to bring parity with how infra does it, we can also update for now to only add the merkleTreeHook to the output to unblock the base problem people are having
update:
restricted to just
merkleTreeHookandinterchainGasPaymasterto provide MVP fixRelated issues
hyperlane-xyz/hyperlane-registry#240 (comment)
hyperlane-xyz/hyperlane-registry#236 (comment)
hyperlane-xyz/hyperlane-registry#237 (comment)
Backward compatibility
yes
Testing
manual