Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Create rateLimitedMultisigIsm.sol #4045

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

skaunov
Copy link
Contributor

@skaunov skaunov commented Jun 24, 2024

needed for hyperlane-xyz/v3-docs#90 via #2231 (comment)

Description

Example of dynamic security based on message contents transfer amounts

Drive-by changes

none

Related issues

relates to #2231
(also needs hyperlane-xyz/v3-docs#90)

Backward compatibility

Yes

Testing

None

Copy link

changeset-bot bot commented Jun 24, 2024

⚠️ No Changeset found

Latest commit: 9fb007a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@skaunov skaunov changed the title Create rateLimitedMultisigIsm.sol docs: Create rateLimitedMultisigIsm.sol Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 60.13%. Comparing base (718d2c2) to head (9fb007a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4045      +/-   ##
==========================================
- Coverage   60.56%   60.13%   -0.44%     
==========================================
  Files         129      130       +1     
  Lines        1656     1668      +12     
  Branches      176      179       +3     
==========================================
  Hits         1003     1003              
- Misses        626      638      +12     
  Partials       27       27              
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 67.50% <ø> (ø)
isms 39.52% <ø> (ø)
token 58.12% <0.00%> (-4.72%) ⬇️
middlewares 77.05% <ø> (ø)

explanatory comments improved and aligned
@yorhodes
Copy link
Member

hey @skaunov , were you blocked on review here?

@skaunov
Copy link
Contributor Author

skaunov commented Sep 24, 2024

hey @yorhodes , I guess more like abandoned for awhile 😆
it's waiting to be reviewed, yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants