Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: random suffix for the oidc pool & provider #12

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix: random suffix for the oidc pool & provider #12

merged 1 commit into from
Nov 8, 2023

Conversation

johanneswuerbach
Copy link
Contributor

GCP prevents to re-use the same id for a OIDC pool & provider for 30 days after deletion. Workaround this by adding a random suffix to both.

@johanneswuerbach johanneswuerbach requested a review from a team as a code owner November 3, 2023 16:32
chrishumanitec
chrishumanitec approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@chrishumanitec chrishumanitec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanneswuerbach johanneswuerbach merged commit d03f646 into humanitec-architecture:main Nov 8, 2023
1 check passed
@johanneswuerbach johanneswuerbach deleted the oidc-suffix branch November 8, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishumanitec chrishumanitec chrishumanitec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanneswuerbach @chrishumanitec