-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate setup.py to setup.cfg #1553
Conversation
4c320b1
to
c173a14
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1553 +/- ##
==========================================
- Coverage 97.28% 94.22% -3.07%
==========================================
Files 67 113 +46
Lines 4235 7705 +3470
==========================================
+ Hits 4120 7260 +3140
- Misses 115 445 +330 ☔ View full report in Codecov by Sentry. |
No man pages
c173a14
to
d55543e
Compare
1b2a7c9
to
a6248e5
Compare
@deronnax thanks for the PR! If we find a way to maintain full compatibility including |
Sorry, I was wrong, it's actually doable. There you go. Don't forget to squash merge. |
@deronnax thanks! |
It looks like the conditional Windows-only stuff like the Lines 44 to 63 in 3524ccf
|
oops sorry. Actually that's tox that's depending colorama. |
Setuptools recommends to use declarative setup.cfg over custom imperative setup.py (especially that this one grown some significant body hair)
On the other hand, using
data_files
(that is used here for man pages) is deprecated and has no direct equivalent in declarative package definition, be itsetup.cfg
orpyproject.toml
, so we might just not be able to replicate the thing.