Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for ionicons 5.0.0 #284

Closed
wants to merge 1 commit into from

Conversation

shaneparsons
Copy link

PR Type

What kind of change does this PR introduce?
Support for ionicons 5.0.0

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Demos changes
[ ] Other... Please describe:

What is the current behavior?

The names of some ionicons changed as of 5.0.0, breaking arrows in the calendar.
Issue Number: #283

What is the new behavior?

The deprecated names have been replaced with their new variants, fixing the broken icons.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

I don't believe the arrows will show correctly for anybody still using ionicons 4.x.x.

Other information

I tried going through your contributing guidelines before submitting this, but I didn't understand the whole dev folder concept and kept getting compiler errors... In frustration, I simply made the bare minimum changes needed, which is what you'll see in this PR.

@shaneparsons shaneparsons changed the title type(fix): add support for ionicons 5.0.0 fix: add support for ionicons 5.0.0 Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant