fix: add support for ionicons 5.0.0 #284
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Support for ionicons 5.0.0
What is the current behavior?
The names of some ionicons changed as of 5.0.0, breaking arrows in the calendar.
Issue Number: #283
What is the new behavior?
The deprecated names have been replaced with their new variants, fixing the broken icons.
Does this PR introduce a breaking change?
I don't believe the arrows will show correctly for anybody still using ionicons 4.x.x.
Other information
I tried going through your contributing guidelines before submitting this, but I didn't understand the whole dev folder concept and kept getting compiler errors... In frustration, I simply made the bare minimum changes needed, which is what you'll see in this PR.